Skip to content

Conversation

@mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jan 21, 2024

😠

@codecov
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3cb0f1) 98.58% compared to head (a38dfd6) 98.58%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3620   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          75       75           
  Lines       24697    24706    +9     
=======================================
+ Hits        24348    24357    +9     
  Misses        349      349           
Files Coverage Δ
seaborn/_base.py 97.90% <100.00%> (ø)
seaborn/_compat.py 60.52% <100.00%> (+2.77%) ⬆️
seaborn/_core/plot.py 99.15% <100.00%> (+<0.01%) ⬆️
seaborn/categorical.py 98.92% <100.00%> (+<0.01%) ⬆️
seaborn/relational.py 99.65% <100.00%> (+<0.01%) ⬆️
tests/_stats/test_density.py 100.00% <100.00%> (ø)
tests/test_categorical.py 99.26% <100.00%> (ø)

@mwaskom mwaskom merged commit 7aed2a0 into master Jan 21, 2024
@mwaskom mwaskom deleted the maint/pandas-2.2.0-compat branch January 21, 2024 01:46
def test_datetime_native_scale_axis(self):

x = pd.date_range("2010-01-01", periods=20, freq="m")
x = pd.date_range("2010-01-01", periods=20, freq="MS")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW if you want to have the same values as before you need "ME" (month end, not month start). Not sure whether that matters for the test, though (you test below with "2003-02-28", which is a "month end")

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah thanks, the test date here being a "month end" is just a coincidence and not critical to the test logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants