Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use oldstable and stable alias a Go version #80

Closed
wants to merge 1 commit into from

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 2, 2024

It allows the CI to automatically follow the "2 latest minor versions of Go" rule.

https://github.com/actions/setup-go?tab=readme-ov-file#using-stableoldstable-aliases

@ldez ldez force-pushed the feat/go-version-alias branch from 2df7a85 to 90fa6ed Compare May 2, 2024 19:01
@mvdan
Copy link
Owner

mvdan commented May 28, 2024

Thanks for the PR, but I stick to specific major versions on purpose, much like go.mod, because I need to be in control of when I add or remove support for a Go version - and so whether CI is testing that version or not.

@mvdan mvdan closed this May 28, 2024
@ldez ldez deleted the feat/go-version-alias branch May 28, 2024 13:02
@ldez
Copy link
Contributor Author

ldez commented May 28, 2024

So can I create a PR to update the CI to go1.21/go1.22 instead of go1.20/go1.21?

@mvdan
Copy link
Owner

mvdan commented May 28, 2024

No need, I'll do that - I will need to do a bunch of other things too, like update dependencies and check that the tool works on Go tip today for 1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants