New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color transform is incorrect. #24

Open

siemanko opened this issue Nov 25, 2016 · 1 comment

siemanko commented Nov 25, 2016

Hey,

so the color transform that you use is incorrect (for example in Seaquest it sometimes causes the fishes to disappear).

async-rl/ale.py

Lines 67 to 68 in 12dac59

    
           img = rgb_img[:, :, 0] * 0.2126 + rgb_img[:, :, 1] * \ 
        
               0.0722 + rgb_img[:, :, 2] * 0.7152

You can get the correct one from the repo Deepmind uses:
https://github.com/torch/image/blob/9f65c30167b2048ecbe8b7befdc6b2d6d12baee9/generic/image.c#L2105)

Let me know how much this improves your results if you decide to adopt this. For me the difference was massive.

Owner

muupan commented Dec 1, 2016

Thank you for pointing it out! I'll check the performance with that transformation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment