Merge pull request #31067 from cbjeukendrup/missing-negation

DmitryArefiev · web-flow · commit 5cf0eed90321 · 2025-11-17T01:50:38.000+02:00
FIx close Preferences dialog due to missing negation
diff --git a/src/framework/shortcuts/internal/midiremote.cpp b/src/framework/shortcuts/internal/midiremote.cpp
@@ -203,7 +203,7 @@ bool MidiRemote::writeMidiMappings(const MidiMappingList& midiMappings) const
 
     writer.endElement();
 
-    return mappingsFile.hasError();
+    return !mappingsFile.hasError();
 }
 
 void MidiRemote::writeMidiMapping(XmlStreamWriter& writer, const MidiControlsMapping& midiMapping) const
diff --git a/src/framework/shortcuts/internal/shortcutsregister.cpp b/src/framework/shortcuts/internal/shortcutsregister.cpp
@@ -369,7 +369,7 @@ bool ShortcutsRegister::writeToFile(const ShortcutList& shortcuts, const io::pat
 
     writer.endElement();
 
-    return file.hasError();
+    return !file.hasError();
 }
 
 void ShortcutsRegister::writeShortcut(XmlStreamWriter& writer, const Shortcut& shortcut) const

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ bool MidiRemote::writeMidiMappings(const MidiMappingList& midiMappings) const`
`203`	`203`
`204`	`204`	`writer.endElement();`
`205`	`205`
`206`		`- return mappingsFile.hasError();`
	`206`	`+ return !mappingsFile.hasError();`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`void MidiRemote::writeMidiMapping(XmlStreamWriter& writer, const MidiControlsMapping& midiMapping) const`
Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ bool ShortcutsRegister::writeToFile(const ShortcutList& shortcuts, const io::pat`
`369`	`369`
`370`	`370`	`writer.endElement();`
`371`	`371`
`372`		`- return file.hasError();`
	`372`	`+ return !file.hasError();`
`373`	`373`	`}`
`374`	`374`
`375`	`375`	`void ShortcutsRegister::writeShortcut(XmlStreamWriter& writer, const Shortcut& shortcut) const`