Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal size is not correctly reported on windows #14

Open
prabirshrestha opened this issue Jan 22, 2020 · 1 comment · May be fixed by #15
Open

terminal size is not correctly reported on windows #14

prabirshrestha opened this issue Jan 22, 2020 · 1 comment · May be fixed by #15

Comments

@prabirshrestha
Copy link

Apparently in Windows in cmd the terminal size is not correctly reported.

In win32 apis there are two sizes - one for window and one for the buffer. Currently it reports the buffer size instead of the window size. So if set the buffer height/lines to 9999, that is the value it returns instead of the window height which is lot smaller.

Seems like need to do a bit more calculation. https://stackoverflow.com/a/12642749

This is not an issue with the new windows terminal, only issue with the cmd.exe.
@murarth murarth linked a pull request Jan 22, 2020 that will close this issue
Open
@murarth
Copy link
Owner

murarth commented Jan 22, 2020

@prabirshrestha Thank you for filing this issue. I've submitted PR #15 to address it. Can you confirm that it gives the correct result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Windows: Correct result of Terminal::size murarth/mortal
2 participants
@prabirshrestha @murarth