Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

munin-node.conf allow is whitespace-sensitive #1645

Open
vanschelven opened this issue Feb 5, 2025 · 0 comments
Open

munin-node.conf allow is whitespace-sensitive #1645

vanschelven opened this issue Feb 5, 2025 · 0 comments

Comments

@vanschelven
Copy link

vanschelven commented Feb 5, 2025

Describe the bug

a munin-node.conf with a line like so won't work:

allow ^123\.123\.123\.123$   # server 123, in Utah

This even extends to trailing whitespace (no comment at all):

allow ^123\.123\.123\.123$       

To Reproduce

Steps to reproduce the behavior:

  1. add allow line with trailing comment to munin-node.conf
  2. restart munin-node
  3. look at the logs
  4. observe Denying connection from: ::ffff:123.123.123.123

For way to long, I experimented with different regexes to match the ::ffff: part of the reported IP in the error-message, but it's irrelevant: the original allow directive is fine, except for the whitespace at the end of the line.

Expected behavior

Comments and trailing whitespace to be ignored (they can never match an IP address or hostname anyway)

Screenshots & Logs
If applicable, please add screenshots and/or logs to help explain your problem.

Desktop (please complete the following information):

  • Ubuntu 24.04
  • This is munin-node v2.0.75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant