Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding text styles has no effect on Windows #332

Open
icy-comet opened this issue Jul 8, 2022 · 5 comments
Open

adding text styles has no effect on Windows #332

icy-comet opened this issue Jul 8, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@icy-comet
Copy link
Contributor

icy-comet commented Jul 8, 2022

I am on the devel branch of termdash and I passed 4 different styles with text.WriteCellOpts to the text.Write call for testing the result. Except, I found only the blink style to be working, as seen in the attached image.

image

Is this an implementation issue at termdash's end or a bug in the upstream lib tcell?

I also tested the same thing with termdash v0.16.0 which was before merging #329, but had the same outcome.

image

Shell: Powershell 7.2.5
Terminal Emulator: Windows Terminal v1.13.11432.0
OS: Windows 11

PS: I know that the styling works on my device because golang-based OhMyPosh, which handles ANSI codes differently, works with all the 4 styles.

@icy-comet icy-comet changed the title adding text styles has no effect adding text styles has no effect on Windows Jul 8, 2022
@icy-comet
Copy link
Contributor Author

I just tested the same program inside WSL, and all the styles work fine with the Linux build.

@mum4k mum4k added the bug Something isn't working label Jul 8, 2022
@mum4k
Copy link
Owner

mum4k commented Jul 8, 2022

Thank you for reporting this @icy-comet, considering this works in Linux, chances are the problem is in upstream tcell. We could start by verifying if the tcell support works as expected by running tcell natively without termdash on windows and selecting these options.

@icy-comet please indicate if you are interested in looking into this issue.

@icy-comet
Copy link
Contributor Author

icy-comet commented Jul 10, 2022

chances are the problem is in upstream tcell

Seems like it @mum4k.

I just put together a test file according to tcell's getting started guide for 4 text styles — italic, bold, blink and dim.

Here are the results:

  • Windows + Windows Terminal + Powershell - only the blink style works
    image
  • Windows + Conhost + cmd - blink and bold styles work
    image
  • WSL2 + Windows Terminal + bash - bold style doesn't work
    image
  • WSL2 + Conhost + bash - all styles work
    image

Here's the gist I used for testing:
https://gist.github.com/icy-comet/76cc7fdbb77f272c5653e533ddebdb63

@icy-comet
Copy link
Contributor Author

I just opened an issue describing this at tcell's issue tracker: gdamore/tcell#539

@mum4k
Copy link
Owner

mum4k commented Jul 14, 2022

Thank you for following up upstream @icy-comet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants