Skip to content

Commit 90c75af

Browse files
committed
Merge branch 'latest' into net
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
2 parents c11c929 + a7a89d1 commit 90c75af

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ To connect to an existing VM with a remote shell, you can use this command:
9999
```bash
100100
docker exec -it \
101101
"$(docker ps --filter "label=name=mptcp-upstream-virtme-docker" -l --format "{{.ID}}")" \
102-
/entrypoint.sh connect
102+
/entrypoint.sh connect [CMD]
103103
```
104104

105105
(Or use the `connect.sh` script.)

entrypoint.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,10 @@ setup_env() { local mode
381381
VIRTME_RUN_OPTS+=("--net")
382382
fi
383383

384-
# From the docker: vng --vsock-connect
384+
# To connect to the VM using VSock
385385
# TODO: remove if condition when virtme-ng supports it
386-
if "${VIRTME_RUN}" -h | grep -q vsock; then
387-
VIRTME_RUN_OPTS+=("--vsock" "--vsock-cid" "${INPUT_VSOCK_CID}")
386+
if "${VIRTME_RUN}" -h | grep -q VSOCK; then
387+
VIRTME_RUN_OPTS+=("--server" "--port" "${INPUT_VSOCK_CID}")
388388
fi
389389
fi
390390

@@ -1886,7 +1886,7 @@ usage() {
18861886
echo " - static: run static analysis, with make W=1 C=1"
18871887
echo " - vm-manual: start the VM with what has already been built ('normal' mode by default)"
18881888
echo " - vm-auto: same, then run the tests as well ('normal' mode by default)"
1889-
echo " - connect: connect to a VM's remote shell via a VSock (set INPUT_VSOCK_CID for multiple VMs)."
1889+
echo " - connect: connect to a VM's remote shell via a VSOCK (set INPUT_VSOCK_CID for multiple VMs)."
18901890
echo " - lcov2html: generate html from lcov file (required INPUT_GCOV=1)"
18911891
echo
18921892
echo "This script needs to be ran from the root of kernel source code."
@@ -2009,7 +2009,7 @@ case "${INPUT_MODE}" in
20092009
analyze "${@:-normal}"
20102010
;;
20112011
"connect")
2012-
exec "${VIRTME_RUN}" --mods none --vsock-connect "${*:2}" --vsock-cid "${1:-${INPUT_VSOCK_CID}}"
2012+
exec "${VIRTME_RUN}" --mods none --client --port "${INPUT_VSOCK_CID}" ${1:+--remote-cmd "${*}"}
20132013
;;
20142014
"lcov2html")
20152015
setup_env "${@:-normal}"

0 commit comments

Comments
 (0)