From 8c84127a9989863fe888909b6b527c70b02e5b71 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Tue, 23 Feb 2021 20:44:07 +0800 Subject: [PATCH] don't listen on all interfaces in tests, unless on CI --- net/net_test.go | 39 ++++++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/net/net_test.go b/net/net_test.go index 51a71e5..94c634f 100644 --- a/net/net_test.go +++ b/net/net_test.go @@ -232,23 +232,28 @@ func TestListenAddrs(t *testing.T) { test("/ip4/127.0.0.1/tcp/4324", "", true) test("/ip4/127.0.0.1/udp/4325", "", false) test("/ip4/127.0.0.1/udp/4326/udt", "", false) - test("/ip4/0.0.0.0/tcp/4324", "", true) - test("/ip4/0.0.0.0/udp/4325", "", false) - test("/ip4/0.0.0.0/udp/4326/udt", "", false) - - test("/ip6/::1/tcp/4324", "", true) - test("/ip6/::1/udp/4325", "", false) - test("/ip6/::1/udp/4326/udt", "", false) - test("/ip6/::/tcp/4324", "", true) - test("/ip6/::/udp/4325", "", false) - test("/ip6/::/udp/4326/udt", "", false) - - /* "An implementation should also support the concept of a "default" - * zone for each scope. And, when supported, the index value zero - * at each scope SHOULD be reserved to mean "use the default zone"." - * -- rfc4007. So, this _should_ work everywhere(?). */ - test("/ip6zone/0/ip6/::1/tcp/4324", "/ip6/::1/tcp/4324", true) - test("/ip6zone/0/ip6/::1/udp/4324", "", false) + + if len(os.Getenv("CI")) > 0 { + test("/ip4/0.0.0.0/tcp/4324", "", true) + test("/ip4/0.0.0.0/udp/4325", "", false) + test("/ip4/0.0.0.0/udp/4326/udt", "", false) + + test("/ip6/::1/tcp/4324", "", true) + test("/ip6/::1/udp/4325", "", false) + test("/ip6/::1/udp/4326/udt", "", false) + test("/ip6/::/tcp/4324", "", true) + test("/ip6/::/udp/4325", "", false) + test("/ip6/::/udp/4326/udt", "", false) + + /* "An implementation should also support the concept of a "default" + * zone for each scope. And, when supported, the index value zero + * at each scope SHOULD be reserved to mean "use the default zone"." + * -- rfc4007. So, this _should_ work everywhere(?). */ + test("/ip6zone/0/ip6/::1/tcp/4324", "/ip6/::1/tcp/4324", true) + test("/ip6zone/0/ip6/::1/udp/4324", "", false) + } else { + t.Skip("all tests only run on CI") + } } func TestListenAndDial(t *testing.T) {