Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto login only if the user is in given groups #10

Open
khalen56 opened this issue Aug 23, 2019 · 4 comments
Open

Auto login only if the user is in given groups #10

khalen56 opened this issue Aug 23, 2019 · 4 comments

Comments

@khalen56
Copy link

khalen56 commented Aug 23, 2019

Hello !

I haven't tried this extension yet because there is one essential missing feature for my usage. I'm currently using another plugin named Auth_phpBB and you can specify forum groups allowed to login to the mediawiki. I would like to switch to your plugin because it's much more convenient to have auto login on the wiki.

I'll fork the project and try to add this feature. Then I could do a pull request if you are interested.

@khalen56
Copy link
Author

khalen56 commented Sep 6, 2019

I've worked a bit, and I think the best way to do it is to create a phpbb extension that adds a permission u_wiki_login then using $auth->acl_get('u_wiki_login') to check if the user is allowed to login.
@ajquick maybe it is too different from your original idea and I should just maintain a fork of your extension ? What do you think ?

@ajquick
Copy link
Contributor

ajquick commented Sep 6, 2019

I do think the group style implementation that was part of Auth_phpBB could be added rather easily. That way you can create a phpBB group and then have this plugin check if they are in that group. It would be a 1 extension solution, rather than having a MediaWiki extension and phpBB extension.

An example of how I would implement it in this extension is how Phpbb Single Sign-On did it: https://www.mediawiki.org/wiki/Extension:Phpbb_Single_Sign-On

@khalen56
Copy link
Author

khalen56 commented Sep 6, 2019

Doing SQL queries with Auth_phpBB was okay, because it was a single query on login, but here it would be a query everytime so, I don't know if it's fine. I think phpbb is caching permissions, it should give better performances but yeah, it's two extensions.

@ajquick
Copy link
Contributor

ajquick commented Sep 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants