Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attributes from traits? #58

Open
jaulz opened this issue Jun 21, 2021 · 0 comments
Open

Remove attributes from traits? #58

jaulz opened this issue Jun 21, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@jaulz
Copy link
Contributor

jaulz commented Jun 21, 2021

Hi @msk286, could we please remove the attributes within the traits by any chance? Right now, when you call "toArray" on the model it runs all the methods of the model and thus fires unneeded SQL queries. Maybe as part of a new major release since it would be a breaking change. If users need it, they can anyway easily define it themselves because the helper methods exist.
@mkwsra mkwsra added the enhancement New feature or request label Feb 18, 2022
@mkwsra mkwsra added help wanted Extra attention is needed and removed enhancement New feature or request labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkwsra @jaulz