Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity per hour of day - no time allocated for 23-00 #56

Closed
williamboman opened this issue Feb 13, 2022 · 1 comment · Fixed by #74
Closed

Activity per hour of day - no time allocated for 23-00 #56

williamboman opened this issue Feb 13, 2022 · 1 comment · Fixed by #74
Labels
bug Something isn't working

Comments

@williamboman
Copy link
Contributor

Hello! I have data on my Hakatime instance going back to 2020, and when I'm looking in the Projects view, in the "Activity per hour of day" chart there's never any hours allocated to 23 (11 PM) - it's 0 all the time. I found this to be a bit odd, maybe it's an off-by-one error somewhere?

@mujx mujx added the bug Something isn't working label Feb 13, 2022
@ablearthy
Copy link
Contributor

Yeah! There's off-by-one error made here.

By the way, I have a question: what if getTimezoneOffset returns a positive value (e.g. off = 2)? Then for v = 0, (0 - (off)) % 24 = -2. I think, it should be fixed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants