Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce every DOM operation to the minimum possible DOM updates #845

Closed
2 tasks done
apedroferreira opened this issue Aug 23, 2022 · 0 comments · Fixed by #1374
Closed
2 tasks done

Reduce every DOM operation to the minimum possible DOM updates #845

apedroferreira opened this issue Aug 23, 2022 · 0 comments · Fixed by #1374
Assignees

Comments

@apedroferreira
Copy link
Member

apedroferreira commented Aug 23, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Right now there are multiple operations in the drag & drop editor that cause multiple updates in the DOM, when one or zero updates would be expected instead. We should make it so that those operations only update the DOM as little as necessary.

See also this issue for more relevant discussion and information - however, that issue is only about hiding the number of changes in the UI: #781

Examples 🌈

Motivation 🔦

Fixing this will enable us to build undo/redo functionality a lot more easily in the future.

@apedroferreira apedroferreira added status: waiting for maintainer These issues haven't been looked at yet by a maintainer feature: App Editor and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 23, 2022
@apedroferreira apedroferreira self-assigned this Aug 23, 2022
@apedroferreira apedroferreira mentioned this issue Sep 7, 2022
10 tasks
@apedroferreira apedroferreira removed their assignment Oct 28, 2022
@apedroferreira apedroferreira self-assigned this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant