Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components overlapping when horizontally resized #826

Closed
2 tasks done
prakhargupta1 opened this issue Aug 18, 2022 · 5 comments · Fixed by #871
Closed
2 tasks done

Components overlapping when horizontally resized #826

prakhargupta1 opened this issue Aug 18, 2022 · 5 comments · Fixed by #871
Assignees
Labels
bug 🐛 Something doesn't work scope: toolpad-studio Abbreviated to "studio"
Milestone

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Aug 18, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Screen.Recording.2022-08-18.at.11.59.46.PM.mov

Not sure if this is the expected behavior as of now.
But sometimes the component is pushing the adjacent one, sometimes it is not.

@prakhargupta1 prakhargupta1 added status: waiting for maintainer These issues haven't been looked at yet by a maintainer bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 18, 2022
@apedroferreira
Copy link
Member

apedroferreira commented Aug 19, 2022

thanks for finding this Prakhar!
are you able to send me the DOM object from the app where you have this issue? that might help me reproduce it and understand it better nevermind, not needed

@apedroferreira
Copy link
Member

oh wait, i think the only issue here is that the resizing is not aware that the text input has a minimum width, so it does not respect it.
this might be a tough issue to fix, but i'll see how we can improve this

@Janpot
Copy link
Member

Janpot commented Aug 19, 2022

We can make it always fullWidth and remove that property? How would we size a texfield that is the only component on a row?

@prakhargupta1
Copy link
Member Author

@apedroferreira In case it helps, here is the link to the app: https://master--toolpad.mui.com/_toolpad/app/cl1on1bd80041a1pdrrfdt0rq/editor/pages/cl6ysktjz00023b6g8xkizxr8

@apedroferreira
Copy link
Member

apedroferreira commented Aug 19, 2022

How would we size a texfield that is the only component on a row?

with some improvements to resizing we could make it possible to adjust the left/right margin in the container to any value (even the top/bottom margins probably), as well as resize the text input horizontally to any possible size. right now it's very basic though so users can't do it yet...

We can make it always fullWidth and remove that property?

as things are for now if we had this type of component always be full width i guess we wouldn't be able to add any margins?
and i guess any imposed minimum width in any component would still create visual issues like these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants