Can't delete an app

[MonstraG]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Current behavior 😯

Expected behavior 🤔

It actually deletes.

Steps to reproduce 🕹

Steps:

1. Create app
2. Go back to list (grid?) of apps
3. Try to delete it.

Context 🔦

No response

Your environment 🌎

No response

[MonstraG]

I don't think I need to create another issue for renaming that doesn't work and deploying that loads for a while but eventually sends to 404.

[bharatkashyap]

I can't seem to be able to replicate this @MonstraG:

Screen.Recording.2022-06-20.at.1.34.49.AM.mov

Could you attach some additional information - perhaps a screenshot from the browser console?

[MonstraG]

[MonstraG]

This happens because it navigates to ? because Delete is a type="submit" button inside of a form.

Changing it to type="button" fixes the problem.

Or, I guess, e.preventDefault would aslo fix it.

[Janpot]

Thanks a lot for trying out Toolpad, I believe we've fixed all issues that have been laid out in this ticket:

1. Delete not working: firefox only issue, solved by Delete confirmation dialog Doesn't need to be a form #579
2. App rename not working on "Enter": solved by Fixing app rename on "Enter" press #580
3. "deploying that loads for a while but eventually sends to 404.": I assume you're talking about the "view" button that 404s when the app hasn't been deployed yet. For now we've disabled the button with a message if there's no deployment. We'll keep working on improving this UX. Disable view button on apps that aren't deployed yet #581

We will release these changes somewhere this week. They can already be tried with the prerelease docker image muicom/toolpad:293892c7271be0dc053afa06675836bcefe507a2 or muicom/toolpad:alpha.

[oliviertassinari]

I see the "regression" label was applied. Is there an opportunity to write some regression tests for them?

[Janpot]

Adding #597