Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimum and maximum value for component number attributes #461

Closed
2 tasks done
apedroferreira opened this issue May 24, 2022 · 2 comments · Fixed by #871
Closed
2 tasks done

Set minimum and maximum value for component number attributes #461

apedroferreira opened this issue May 24, 2022 · 2 comments · Fixed by #871
Labels
feature: App Editor priority: low To delay as much as possible scope: toolpad-studio Abbreviated to "studio"

Comments

@apedroferreira
Copy link
Member

apedroferreira commented May 24, 2022 •
edited
Loading

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Right now, for component properties that have a number value, any integer value can be set, including negative numbers.
For some for these attributes, we want there to be a minimum and maximum value that can be set.
This will make it less likely for the layout to break, or any other unintended behaviors to happen.

Examples 🌈

No response

Motivation 🔦

No response
@apedroferreira apedroferreira added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 24, 2022
@Janpot Janpot added priority: low To delay as much as possible feature: App Editor and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 28, 2022
@prakhargupta1 prakhargupta1 added this to the backlog milestone May 31, 2022
@prakhargupta1
Copy link
Member

Is it related to all or some particular components?
Where do we show 'component number attributes'?

@apedroferreira
Copy link
Member Author

apedroferreira commented Aug 18, 2022 •
edited
Loading

Is it related to all or some particular components? Where do we show 'component number attributes'?

It could help in any UI controls for components that use numbers, even new custom components - for example if a row has a giant gap value like 9999 it would probably break the layout pretty bad.
This probably isn't high priority for now as we don't have that many cases/components where something like this can have bad consequences?

Screen Shot 2022-08-18 at 16 36 38

Screen Shot 2022-08-18 at 16 36 49

@prakhargupta1 prakhargupta1 removed this from the Backlog milestone Aug 29, 2022
@apedroferreira apedroferreira mentioned this issue Aug 30, 2022
Merged
@oliviertassinari oliviertassinari added the scope: toolpad-studio Abbreviated to "studio" label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: App Editor priority: low To delay as much as possible scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow minimum and maximum value for component number props mui/toolpad
4 participants
@Janpot @oliviertassinari @apedroferreira @prakhargupta1