[examples] Fix vite example & add dark mode support #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
changed the title
brijeshb42
reviewed
Dec 4, 2024
examples/pigment-css-vite-ts/src/components/ColorSchemeProvider.tsx
Outdated
Show resolved
Hide resolved
brijeshb42
approved these changes
Dec 4, 2024
brijeshb42
approved these changes
Dec 5, 2024
|
@mnajdova @brijeshb42 Would this aim to fix mui/material-ui#43487 (comment)? This used to work, but no longer appears to be. |
|
Yes. This should have fixed the issue. Can you try the latest example? |
|
|
Are you trying the example from Material ui repo or Pigment CSS repo?
…On Thu, Dec 5, 2024, 3:48 PM Brandon Fitzwater ***@***.***> wrote:
Yes. This should have fixed the issue. Can you try the latest example?
I just tried the example and I'm still receiving this Screenshot.2024-12-05.at.5.17.56.AM.png
(view on web)
<https://github.com/user-attachments/assets/26bceb37-58cd-4137-b79d-7fece87c9d83>
—
Reply to this email directly, view it on GitHub
<#340 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFPF3U7SMOKIB7STVRY7CT2EASAXAVCNFSM6AAAAABTAMCKHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJZHA3DMNZRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I had been using the example from the Material UI repository. It had worked well until recently. I tried the Pigment CSS repository and it looks like it does render, so I guess I'll just have to find the delta between the two repositories. Any ideas off the top of your head? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works similar to the Material UI + Pigment CSS next.js example in terms of dark mode support.