Skip to content

[pickers] Add inputSizeSmall to classes interface #18242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025
Merged

[pickers] Add inputSizeSmall to classes interface #18242

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44e1f89
[Pickers] Add `inputSizeSmall` to classes interface
sai6855 Jun 5, 2025
317cb22
Merge branch 'master' into add-input-size-class
sai6855 Jun 5, 2025
140d2f4
Add missing class entry
LukasTy Jun 12, 2025
5d38ab2
Merge branch 'master' into add-input-size-class
LukasTy Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/x-date-pickers/src/PickersTextField/PickersInputBase/pickersInputBaseClasses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ export interface PickersInputBaseClasses {
readOnly: string;
/** State class applied to the root element if `error=true`. */
error: string;
/** State class applied to the root element if `size=small`. */
Copy link
Contributor Author

@sai6855 sai6855 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t add @deprecated here because, in the @mui/material TextField component, inputSizeSmall is deprecated due to the presence of both input and sizeSmall (https://mui.com/material-ui/api/input-base/#input-base-classes-MuiInputBase-sizeSmall) classes. However, in PickersInputBase, the sizeSmall class isn’t available, so it’s not possible to compose the sizeSmall class in this context.

Additionally we can add sizeSmall class and then deprecate inputSizeSmall and make it consistent with @mui/material TextField. Let me know, if we want to take that approach

Copy link
Member

@LukasTy LukasTy Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the context.
Yes, I agree with your choice.
If there is a significant demand, we can align the API of the PickersTextField to be more in line with the new API of TextField, but I think this is a good enough first step and it fixes the open issue. 👌

inputSizeSmall: string;
/** Styles applied to the NotchedOutline element. */
notchedOutline: string;
/** Styles applied to the real hidden input element. */
Expand Down Expand Up @@ -52,6 +54,7 @@ export const pickersInputBaseClasses = generateUtilityClasses<PickersInputBaseCl
'adornedStart',
'adornedEnd',
'input',
'inputSizeSmall',
'activeBar',
],
);