Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Show a banner with a warning on deploy previews #5869

Open
cherniavskii opened this issue Aug 22, 2022 · 3 comments
Open

[RFC] Show a banner with a warning on deploy previews #5869

cherniavskii opened this issue Aug 22, 2022 · 3 comments
Labels
docs Improvements or additions to the documentation RFC Request For Comments

Comments

@cherniavskii
Copy link
Member

cherniavskii commented Aug 22, 2022

What's the problem? 🤔

Sometimes we share deploy previews with our users to showcase the feature before it's released or to demonstrate a bugfix.

Users might get confused and expect the feature to be released publicly, which is not the case (I think @joserodolfofreitas mentioned that we had support requests regarding this).
Or they might find an old deployment preview URL in the issues, but the API has changed since.

What are the requirements? ❓

No response

What are our options? 💡

No response

Proposed solution 🟢

To avoid these confusions, we might want to add a warning for all deployment previews, similar to what we have on https://v4.mui.com/ to make it clear that this is a preview and some features might not be publicly released yet
Screenshot 2022-08-22 at 13 01 57

Relevant resources/benchmarks 🔗

No response

@cherniavskii cherniavskii added the RFC Request For Comments label Aug 22, 2022
@oliviertassinari
Copy link
Member

@DanailH DanailH added the docs Improvements or additions to the documentation label Aug 22, 2022
@Janpot
Copy link
Member

Janpot commented Aug 22, 2022

It would be cool to update these PRs description to give more context on why

👍 done

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 22, 2022

Another example of another project doing this: https://github.com/react-bootstrap/react-bootstrap

Screenshot 2022-08-22 at 16 17 42

https://deploy-preview-6378--react-bootstrap.netlify.app/getting-started/introduction


@Janpot Thanks, so these Toolpad PRs that I linked are not directly related to this RFC. I thought that the idea was to help the Toolpad community contributors when they open a Render preview deployment. But no, it's for the actual people using Toolpad when they are previewing their applications e.g.

Screenshot 2022-08-22 at 16 13 44

https://master--toolpad.mui.com/app/cl42qt2jx01249xnr14xjce8b/preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation RFC Request For Comments
Projects
Status: Backlog
Development

No branches or pull requests

4 participants