Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link can't be found #2207

Closed
EugeneGohh opened this issue Jul 25, 2021 · 6 comments
Closed

Link can't be found #2207

EugeneGohh opened this issue Jul 25, 2021 · 6 comments
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation v5.x
Milestone
v5 stable version

Comments

@EugeneGohh
Copy link

https://next.material-ui.com/components/data-grid/layout/
@oliviertassinari oliviertassinari transferred this issue from mui/material-ui Jul 25, 2021
@DanailH DanailH added the docs Improvements or additions to the documentation label Jul 26, 2021
@DanailH
Copy link
Member

DanailH commented Jul 26, 2021

Seems we forgot to add the link in and navigation item in the core / v5 branch

@oliviertassinari oliviertassinari added this to the stable release milestone Aug 2, 2021
@studyhog
Copy link
Contributor

studyhog commented Aug 4, 2021

I can attempt to fix this if nobody's working on it.

@oliviertassinari
Copy link
Member

@studyhog Thanks for the interest however solving this issue will require a deep refactoring of the codebase.

Regarding the others that wonder how to reproduce:

  1. Open https://next.material-ui.com/components/typography/
  2. Click on Layout

Capture d’écran 2021-08-07 à 00 40 54

We have been aware of this issue for some time now, see our SEO crawler:

Capture d’écran 2021-08-07 à 00 41 19

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 16, 2021 •
edited
Loading

It should be fixed with #1902, but to double-check.

@oliviertassinari oliviertassinari modified the milestones: stable release, Sprint 21 Aug 16, 2021
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Sep 6, 2021
@oliviertassinari oliviertassinari modified the milestones: Sprint 21, Sprint 22 Sep 6, 2021
@EugeneGohh
Copy link
Author

In current version "v5.0.0-rc.0" of MaterialUI, looks like the section on Components -> Data Grid section. Many of the links lead to page not found. For example, https://next.material-ui.com/components/data-grid/style/

@m4theushw
Copy link
Member

This was fixed after the merge of the master branch into next.

I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation v5.x
Projects
None yet
Milestone
v5 stable version
Development

No branches or pull requests
5 participants
@oliviertassinari @DanailH @m4theushw @studyhog @EugeneGohh