[DataGrid] Fix number filter field formatting values while typing #16062
+67
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
component: data grid
arminmeh
commented
Jan 2, 2025
| @@ -366,7 +366,11 @@ const GridHeaderFilterCell = forwardRef<HTMLDivElement, GridHeaderFilterCellProp | |||
| disabled={isFilterReadOnly || isNoInputOperator} | |||
| tabIndex={-1} | |||
| InputLabelProps={null} | |||
| sx={colDef.type === 'date' || colDef.type === 'dateTime' ? dateSx : undefined} | |||
| sx={ | |||
| colDef.type === 'date' || colDef.type === 'dateTime' || colDef.type === 'number' | |||
There was a problem hiding this comment.
this is to cover cases when the field is focused out but the value is invalid (like 1e)
adds the same UX as leaving the date filter incomplete
|
Deploy preview: https://deploy-preview-16062--material-ui-x.netlify.app/ |
cherniavskii
approved these changes
Jan 3, 2025
packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputValue.tsx
Outdated
Show resolved
Hide resolved
cherniavskii
reviewed
Jan 3, 2025
packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputValue.tsx
Outdated
Show resolved
Hide resolved
…erInputValue.tsx Signed-off-by: Andrew Cherniavskii <[email protected]>
|
Cherry-pick PRs will be created targeting branches: v7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16052
Regression of #15829