Skip to content

Commit 3f20522

Browse files
authored
[code-infra] Make engine version requirement strict (#552)
1 parent b322fc4 commit 3f20522

File tree

7 files changed

+15
-8
lines changed

7 files changed

+15
-8
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ parameters:
99
default-job: &default-job
1010
working_directory: /tmp/mui
1111
docker:
12-
- image: cimg/node:24.3
12+
- image: cimg/node:22.18
1313
environment:
1414
DANGER_DISABLE_TRANSPILATION: 'true'
1515

.github/workflows/ci-base.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ name: PR Releases
33
on:
44
workflow_call:
55
inputs:
6+
# For backwards compatibility
67
node-version:
78
description: 'Node.js version to use'
8-
required: true
9+
required: false
910
type: string
11+
default: ''
1012
use-compact-url:
1113
description: 'Use compact URLs for pkg.pr.new'
1214
required: false
@@ -33,10 +35,16 @@ jobs:
3335
fetch-depth: 0
3436
- name: Set up pnpm
3537
uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
36-
- name: Use Node.js ${{ inputs.node-version }}
38+
- name: Use specific Node.js version
3739
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
40+
if: ${{ inputs.node-version != '' }}
3841
with:
3942
node-version: ${{ inputs.node-version }}
43+
- name: Use Node.js version from repo
44+
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
45+
if: ${{ inputs.node-version == '' }}
46+
with:
47+
node-version-file: 'package.json'
4048
# https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies
4149
cache: 'pnpm'
4250
- run: pnpm install

.github/workflows/ci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,3 @@ jobs:
1313
continuous-releases:
1414
name: CI Releases
1515
uses: ./.github/workflows/ci-base.yml
16-
with:
17-
node-version: 22

apps/code-infra-dashboard/netlify.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
targetPort = 3000
1414

1515
[build.environment]
16-
NODE_VERSION = "20"
16+
NODE_VERSION = "22.18"
1717

1818
[functions]
1919
directory = "functions"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,6 @@
6161
"packageManager": "[email protected]",
6262
"engines": {
6363
"pnpm": "10.15.0",
64-
"node": ">=18.0.0"
64+
"node": ">=22.18"
6565
}
6666
}

pnpm-workspace.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ overrides:
77
# and to eslint for another instance, causing a conflict.
88
# This should not be an issue for end users, but it is a problem for the monorepo.
99
'@types/eslint': 'npm:eslint@^9.29.0'
10+
engineStrict: true

update-netlify-ignore.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const packageName = process.argv[2];
99

1010
if (!packageName) {
1111
console.error(
12-
'Error: Package name is required. Usage: node update-netlify-ignore.js <package-name>',
12+
'Error: Package name is required. Usage: node update-netlify-ignore.mjs <package-name>',
1313
);
1414
process.exit(1);
1515
}

0 commit comments

Comments
 (0)