Skip to content

Commit 3484abc

Browse files
committed
[infra] Make engine version requirement strict
1 parent 3b2a636 commit 3484abc

File tree

7 files changed

+9
-11
lines changed

7 files changed

+9
-11
lines changed

.github/workflows/ci-base.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ name: PR Releases
33
on:
44
workflow_call:
55
inputs:
6-
node-version:
7-
description: 'Node.js version to use'
8-
required: true
9-
type: string
106
use-compact-url:
117
description: 'Use compact URLs for pkg.pr.new'
128
required: false
@@ -33,10 +29,10 @@ jobs:
3329
fetch-depth: 0
3430
- name: Set up pnpm
3531
uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
36-
- name: Use Node.js ${{ inputs.node-version }}
32+
- name: Use Node.js
3733
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
3834
with:
39-
node-version: ${{ inputs.node-version }}
35+
node-version-file: 'package.json'
4036
# https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies
4137
cache: 'pnpm'
4238
- run: pnpm install

.github/workflows/ci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,3 @@ jobs:
1313
continuous-releases:
1414
name: CI Releases
1515
uses: ./.github/workflows/ci-base.yml
16-
with:
17-
node-version: 22

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Setup Node.js
3636
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
3737
with:
38-
node-version: 22.18.0
38+
node-version-file: 'package.json'
3939
# https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies
4040
cache: 'pnpm'
4141
registry-url: 'https://registry.npmjs.org'

apps/code-infra-dashboard/netlify.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
targetPort = 3000
1414

1515
[build.environment]
16-
NODE_VERSION = "20"
16+
NODE_VERSION = "22"
1717

1818
[functions]
1919
directory = "functions"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,6 @@
5959
"packageManager": "[email protected]",
6060
"engines": {
6161
"pnpm": "10.14.0",
62-
"node": ">=18.0.0"
62+
"node": ">=22.0.0"
6363
}
6464
}

pnpm-workspace.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ overrides:
77
# and to eslint for another instance, causing a conflict.
88
# This should not be an issue for end users, but it is a problem for the monorepo.
99
'@types/eslint': 'npm:eslint@^9.29.0'
10+
engineStrict: true

renovate.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
{
22
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
33
"extends": ["github>mui/mui-public//renovate/default"],
4+
"constraints": {
5+
"node": ">=22.0.0"
6+
},
47
"schedule": "* 5-9 * * 7",
58
"lockFileMaintenance": {
69
"schedule": "* 0-4 3 * *"

0 commit comments

Comments
 (0)