Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript: Fixed StyledComponent having StyledComponentProps external dependency #8771

Closed
wants to merge 1 commit into from
Closed

Typescript: Fixed StyledComponent having StyledComponentProps external dependency #8771

wants to merge 1 commit into from

Conversation

lukeggchapman
Copy link
Contributor

Had a crack at fixing #8764

@pelotom
Copy link
Member

pelotom commented Oct 20, 2017 •
edited
Loading

I don't view this as something that needs to be addressed in material-ui itself. It's a known issue with TypeScript, and the fix is simple for downstream libraries: import any types that you are implicitly re-exporting. Making this change here makes material-ui's source more complex and less readable. And it's a slippery slope: why should only StyledComponentProps get this special treatment? In the limit, any type declared in material-ui that is used in an exported signature could suffer from this issue.

@oliviertassinari
Copy link
Member

@pelotom I agree with your points. This is something outside of the scope of Material-UI. I have closed the corresponding issue for the same reason.

@lukeggchapman lukeggchapman mentioned this pull request Oct 20, 2017
Closed
1 task
@snyk-bot snyk-bot mentioned this pull request Jun 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukeggchapman @pelotom @oliviertassinari