-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[select] Fix keyboard navigation while rendering in shadow DOM #47380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ZeeshanTamboli
merged 19 commits into
mui:master
from
xBlizZer:fix/select-keyboard-shadowdom
Dec 1, 2025
+71
−13
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b9a1752
fixes focus handling in a Select component while running in shadowDom
xBlizZer 0cddc93
Merge branch 'master' into fix/select-keyboard-shadowdom
xBlizZer 2a70d87
Merge branch 'master' into fix/select-keyboard-shadowdom
ZeeshanTamboli 9189775
rerun CI
ZeeshanTamboli e3fae01
replace `doc.activeElement` with `getActiveElement`
xBlizZer 890e573
prettier fix
xBlizZer c3dbf0e
Merge branch 'master' into fix/select-keyboard-shadowdom
ZeeshanTamboli 917cfd4
Merge branch 'fix/select-keyboard-shadowdom' of https://github.com/xB…
ZeeshanTamboli 8436fd8
Merge branch 'master' into fix/select-keyboard-shadowdom
ZeeshanTamboli e499977
add test
ZeeshanTamboli f859805
fix test
ZeeshanTamboli a199723
prettier
ZeeshanTamboli ea217b2
fix test
ZeeshanTamboli 320ccd3
remove only
ZeeshanTamboli 068954f
try test changes
ZeeshanTamboli ea8697b
fix test
ZeeshanTamboli b05563b
revert FocusTrap changes to test if the test fails or not
ZeeshanTamboli bdc576c
Revert "revert FocusTrap changes to test if the test fails or not"
ZeeshanTamboli e4a0c5f
Merge branch 'master' into fix/select-keyboard-shadowdom
ZeeshanTamboli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to make changes in FocusTrap file if the issue is for Select?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change the FocusTrap because otherwise, when the Select opens, items don’t get focused automatically.
Select → Menu → Popover → Modal → FocusTrap