Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update remix example to restore from error pages #30592

Merged
merged 4 commits into from
Jan 20, 2022

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Jan 12, 2022

Closes #30436

Based on #30436 (comment) with small adjustments to avoid double rendering.

Credits go to @lvauvillier for the initial implementation.

@mui-bot
Copy link

mui-bot commented Jan 12, 2022

No bundle size changes

Generated by 🚫 dangerJS against be3d49e

// reset cache to reapply global styles
clientStyleData.reset();
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to run only once, the effect it's basically what is changing the emotionCache, so we cannot add those in the dependency

@mnajdova mnajdova marked this pull request as ready for review January 13, 2022 06:07
@mnajdova mnajdova requested a review from a team January 13, 2022 06:08
@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Jan 14, 2022
@mnajdova mnajdova requested a review from siriwatknp January 19, 2022 10:34
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great!

@mnajdova mnajdova merged commit ad4420d into mui:master Jan 20, 2022
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@nojitsi
Copy link

nojitsi commented Mar 23, 2023

Helps a lot implementing the solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[examples] MUI is missing style when navigating back from error page in remix example
6 participants