-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add react-media-material-ui in the related projects #12068
Conversation
I see, it's an alternative to the Hidden component. I plan on working on a Display component in the future. I'm not very happy with the Hidden component right now. Also, one more important helper I want to work on is the Spacing. Most of the custom CSS we use on our pages product is about adding spacing. We might be able to abstract it like Bootstrap is doing. |
Hah! I didn't know about the Hidden component. What is it you're not happy about with it? |
@jedwards1211 The hidden use case is too narrow, the behavior is inconsistent between the js and css implementation: #11850. |
@oliviertassinari I just wanted to point out, I just learned about <BreakpointMedia max="sm">
{(matches) => (
<Dialog
fullScreen={matches} |
@jedwards1211 Or even: https://material-ui.com/layout/breakpoints/#render-props. <WithWidth>
{({ width }) => <Typography variant="subtitle1">Current width: {width}</Typography>}
</WithWidth> |
Ah cool, the render prop version |
@jedwards1211 Yeah, given how popular this pattern is, it's something we can expose directly. |
just a little utility package I made :)