Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename withResponsiveFullScreen and expose from index.js #8753

Closed
RohovDmytro opened this issue Oct 19, 2017 · 5 comments
Closed

Rename withResponsiveFullScreen and expose from index.js #8753

RohovDmytro opened this issue Oct 19, 2017 · 5 comments
Assignees
@oliviertassinari
Labels
component: dialog This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@RohovDmytro
Copy link

  • make withResponsiveFullScreen name more Dialog specific.
  • expose withResponsiveFullScreen from index.js

I am not sure about renaming, but exporting function with current name from index.js might be confusing.
@oliviertassinari
Copy link
Member

expose withResponsiveFullScreen from index.js

@rogovdm Yes, as long as the module is public, I think that we should be exporting it in the index.

@rosskevin do you think we should rename the helper?

@oliviertassinari oliviertassinari added the new feature New feature or request label Oct 19, 2017
@rosskevin
Copy link
Member

I'm fine with that. We had some discussion about also changing the transition to slide in there, and making it withMobileDialog or something like that.

@oliviertassinari
Copy link
Member

👍 for the withMobileDialog wording. @rogovdm Do you want to take care of the changes?

@oliviertassinari oliviertassinari added component: dialog This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. labels Oct 19, 2017
@oliviertassinari oliviertassinari self-assigned this Nov 1, 2017
@RohovDmytro
Copy link
Author

Do not have time to jump into. But will help by creating some more issues | suggestions.

@oliviertassinari
Copy link
Member

@rogovdm I will take care of this one.

@oliviertassinari oliviertassinari mentioned this issue Nov 1, 2017
Merged
@snyk-bot snyk-bot mentioned this issue Jun 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
component: dialog This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rosskevin @RohovDmytro @oliviertassinari