Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Deprecate components and componentsProps props #41279

Closed
17 tasks done
DiegoAndai opened this issue Feb 26, 2024 · 9 comments
Closed
17 tasks done

[material-ui] Deprecate components and componentsProps props #41279

DiegoAndai opened this issue Feb 26, 2024 · 9 comments
Assignees
Labels
deprecation New deprecation message package: material-ui Specific to @mui/material

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Feb 26, 2024

Part of #40417

Description

Deprecate components and componentsProps props, which are planned for removal in v7.

  • These are deprecated in favor of the slot pattern: slots and slotProps
  • If the slots or slotProps props do not exist:
    • They must be implemented in the same PR in which the deprecation is added
    • They should have the same type as the deprecated prop
  • The PR introducing the deprecation must also add:

Example PR

Contributing

Feel free to take any components that still need to be done or in progress. Please mention this issue in your PR so we can link it in the description and keep it up to date.

Components to migrate

Search keywords: deprecation components componentsProps material-ui

@DiegoAndai DiegoAndai added deprecation New deprecation message package: material-ui Specific to @mui/material ready to take Help wanted. Guidance available. There is a high chance the change will be accepted labels Feb 26, 2024
@DiegoAndai DiegoAndai self-assigned this Feb 26, 2024
@DiegoAndai DiegoAndai changed the title [material-ui] Add components and componentsProps deprecations [material-ui] Deprecate components and componentsProps props Feb 26, 2024
@aacevski
Copy link
Contributor

Hello, I'd like to take on Backdrop.

@DiegoAndai
Copy link
Member Author

Hey @aacevski, assigned! Feel free to let me know if you need any help.

@ChronicusUA
Copy link
Contributor

Hello I'd like to take InputBase component

@ChronicusUA
Copy link
Contributor

After I added deprecated comment to InputBase the 3 other input components (Input, FilledInput and OutlinedInput) are automatically updated. Seems like we need to prepare 1 PR to update the all 4. Are ok with that or you prefer to prepare 4 PRs for each of them?

@ChronicusUA
Copy link
Contributor

Hello I'd like to take Tooltip component

@ChronicusUA
Copy link
Contributor

I will take Popper as well

@sai6855
Copy link
Contributor

sai6855 commented May 3, 2024

@ChronicusUA id suggest you hold off creating more PR's until your current PRs are reviewed and merged. As it will be difficult for maintainers to manage and review multiple PRs

@DiegoAndai
Copy link
Member Author

Hey @ChronicusUA, sorry for not replying earlier. Thanks for working on these. I'll review the PRs now. As @sai6855 suggested, let's work on the current ones before moving on to other components 🙌🏼

@DiegoAndai DiegoAndai moved this to In progress in Material UI May 27, 2024
@DiegoAndai DiegoAndai added this to the Material UI: v6 milestone May 27, 2024
@DiegoAndai DiegoAndai removed the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label May 31, 2024
@DiegoAndai DiegoAndai moved this from In progress to Done in Material UI Jun 3, 2024
@DiegoAndai
Copy link
Member Author

This issue has been completed! 🎉

Thanks to everyone who contributed, you've helped Material UI become a more consistent library 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation New deprecation message package: material-ui Specific to @mui/material
Projects
Status: Done
Development

No branches or pull requests

4 participants