Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global presets of MD2 "Material Studies" for the theme provider #18908

Closed
1 task done
dohomi opened this issue Dec 18, 2019 · 4 comments
Closed
1 task done

Add global presets of MD2 "Material Studies" for the theme provider #18908

dohomi opened this issue Dec 18, 2019 · 4 comments
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation

Comments

@dohomi
Copy link
Contributor

dohomi commented Dec 18, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Material Studies are very nice showcases and presets as a starting point for new projects. The main page can be found here:
https://material.io/design/material-studies/about-our-material-studies.html

It would be great if Material-UI would introduce presets additionally to the current theming of a default light and dark theme.

Examples 🌈

This is a list of all current studies:
https://material.io/design/material-studies/basil.html
https://material.io/design/material-studies/crane.html
https://material.io/design/material-studies/fortnightly.html
https://material.io/design/material-studies/owl.html
https://material.io/design/material-studies/rally.html
https://material.io/design/material-studies/reply.html
https://material.io/design/material-studies/shrine.html

It would be great if for example the Material-UI customization (https://material-ui.com/customization/color/#color-tool) extends with this presets

Motivation 🔦

It would be great if the theme presets would be available to kickstart a new project. This is how I an example code could look like:

import { basil } from '@matarial-ui/core/presets'
import { createMuiTheme, ThemeProvider } from '@material-ui/core/styles'
const theme = createMuiTheme({
  preset: basil,
  overrides:{/* some customizations */}
})
@eps1lon
Copy link
Member

eps1lon commented Dec 19, 2019

I'm really looking forward to this as a common critique of Material-UI is that it "all looks the same".

It's not that important that these become part of the @material-ui scope (it's already hard to maintain the base theme). Rather we should use this as stress test for our theming API from which we can improve it.

I think a good start would be to to implement these themes with createMuiTheme() and report back any progress that is made.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Dec 19, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 19, 2019

Long term, I think that it would be great to provide other themes like fluent (Microsoft) or antd outside of the box, at least to demonstrate the theming capabilities and to help us improve it. I have seen Vuetify having some plan with the Material Studies. I think that @eps1lon is right, we might want to rely on the community for this, it might be better to provide a theme builder in the docs first before considering more.

@dohomi
Copy link
Contributor Author

dohomi commented Dec 23, 2019

@oliviertassinari Vuetify just landed the presets as part of next branch: https://dev.vuetifyjs.com/en/customization/presets

@oliviertassinari oliviertassinari added the design This is about UI or UX design, please involve a designer label Oct 10, 2020
@oliviertassinari oliviertassinari added design: material This is about Material Design, please involve a visual or UX designer in the process and removed design This is about UI or UX design, please involve a designer labels May 22, 2022
@mapache-salvaje
Copy link
Contributor

I think we can go ahead and close this as not planned since we're currently in the process of moving on to MD3. But we do indeed have something akin to these theme presets in mind for a future major, so it's cool to see the historical context here. 😁

@mapache-salvaje mapache-salvaje closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

4 participants