-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] Some of the components are not visible or rendered properly in Windows High Contrast Mode #13174
Comments
Could it be a duplicate of #12710? |
I'm going to look into the Windows mode but I fear this might not be in our power. High Contrast extension from google chrome displays them perfectly well: That is the default mode (inverted color). All other modes look good as well. Maybe our color scheme is not suited for this mode. |
I also tested the Colour schemes in Windows (which is a separate option) and everything works fine. The issue is with material ui components are not visible in High Contrast Mode in Windows. |
@anandbkrishnamohan Does it mean we can close the issue? |
@oliviertassinari maybe you got confused with the way I wrote the sentence. The issue is that some of the material-ui components are not visible in high contrast mode - it is not a problem with high contrast mode. As @eps1lon mentioned it may be the color scheme is not suited for this mode. |
Any update on this issue ?
Please let me when this issue will be addressed. Thanks, |
@nagvbt Yes, you are the update :). Did you test Windows High Contrast Mode with v5? Does it work? If it's not working what's failing? If it's failing, did you look into how we could solve it? |
@sarahannnicholson Is there a media query to detect when Windows is in high contrast mode? Did you try to customize the theme to fix this? |
Hey @oliviertassinari yeah there's a media query but it's not standardized yet. Also some colors that pick up the different high contrast mode themes. I added the media query to my MUI theme:
Then in a component's JSS I would do something like
and Linear Progress Component
|
@oliviertassinari Found a different media query that is more standardized @media forced-colors Ref: Windows Blog We recently changed our MUI theme to:
Would be great if this was supported in MUI. We are wrapping nearly every component to add these High Contrast Styles. |
With the risk of this being off topic @sarahannnicholson, but I'm wondering in what circumstances will you be applying the whiteOnBlack and blackOnWhite media queries with In my understanding, invert defeats the purpose of Windows High Contrast Mode / Forced Colors mode, which is to let the user set their desired colors on the system level and having them apply everywhere. The invert filter would interfere and render things white that the user wants to be black, and vice versa. Right? (edited after reading your post more closely 🙂 ) |
Hey @fymmot ! I always try to use the general media query and the CSS colors to target high contrast users since users are able to adjust the windows theme to their preferences. For the other queries, white on black and the black on white I mostly use them for changing high contrast of images. We have a lot of black pngs or white pngs on our site, hence the invert. |
While testing our application in Windows High Contrast Mode (Both ie11 and Edge), could see that some of the material-ui/core components are not visible or rendered properly. Reproduced the issues while accessing the Demo Components in material-ui page (https://material-ui.com/)
Expected Behavior
In Windows High Contrast Mode, all elements should be visible and user friendly.
Current Behavior
In Windows High Contrast Mode, the below components are not behaving as expected
Steps to Reproduce
Context
Our application is used by many users who have visual problems and need to make sure it's accessible to all users across platforms.
Your Environment
The text was updated successfully, but these errors were encountered: