Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extendedFAB broken in IE11 #12114

Closed
2 tasks done
koshea opened this issue Jul 11, 2018 · 2 comments
Closed
2 tasks done

extendedFAB broken in IE11 #12114

koshea opened this issue Jul 11, 2018 · 2 comments
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@koshea
Copy link
Contributor

koshea commented Jul 11, 2018 •
edited
Loading

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

The extendedFAB button should display normally in IE 11.

Current Behavior

Only the icon displays, the text is cut off. It appears this is because IE 11 does not support width: initial. I was able to fix it in my application by overriding that to width: auto but I am not sure if that is a perfect solution.

Steps to Reproduce (for bugs)

  1. View the page at https://material-ui.com/demos/buttons/ and see the Extended FAB example. Screenshot attached.

2018-07-11-125635_5120x1440_scrot

Context

Your Environment

Tech Version
Material-UI v1.3.1
React
browser IE11
etc
@mbrookes mbrookes added the component: button This is the name of the generic UI component, not the React module! label Jul 11, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. labels Jul 11, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 11, 2018 •
edited
Loading

@koshea Thanks for raising the issue! The issue comes from this line:
https://github.com/mui-org/material-ui/blob/355317fb479dc234c6b1e374428578717b91bdc0/packages/material-ui/src/Button/Button.js#L138
IE11 doesn't support the initial value. So we need to set the initial value ourselves: auto.

Do you want to work on a pull request? :)

@koshea
Copy link
Contributor Author

koshea commented Jul 12, 2018

Sure, I found one other instance in core that uses initial and created a pull request #12199

@koshea koshea mentioned this issue Jul 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbrookes @koshea @oliviertassinari