Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type errors with @material-ui/core 3.9.2 #896

Closed
benneq opened this issue Feb 3, 2019 · 3 comments
Closed

Type errors with @material-ui/core 3.9.2 #896

benneq opened this issue Feb 3, 2019 · 3 comments

Comments

@benneq
Copy link

benneq commented Feb 3, 2019

A GIF or MEME to give some spice of the internet

Environment

Tech Version
material-ui-pickers 2.1.2
material-ui 3.9.2
React 16.8.0-alpha.1
Browser Chrome
Peer library "@date-io/moment": "1.0.2"

Steps to reproduce

  1. Update @material-ui/core from 3.9.1 to 3.9.2
  2. npm i
  3. npm start

Expected behavior

no errors

Actual behavior

node_modules/material-ui-pickers/DatePicker/components/Calendar.d.ts(65,70):
TS2344: Type '"date" | "classes" | "onChange" | "innerRef" | "theme" | "minDate" | "disablePast" | "disableFuture" | "maxDate" | "shouldDisableDate" | "leftArrowIcon" | "rightArrowIcon" | "renderDay" | "allowKeyboardControl"' does not satisfy the constraint '"date" | "classes" | "onChange" | "theme" | "utils" | "minDate" | "disablePast" | "disableFuture" | "maxDate" | "shouldDisableDate" | "leftArrowIcon" | "rightArrowIcon" | "renderDay" | "allowKeyboardControl"'.
  Type '"innerRef"' is not assignable to type '"date" | "classes" | "onChange" | "theme" | "utils" | "minDate" | "disablePast" | "disableFuture" | "maxDate" | "shouldDisableDate" | "leftArrowIcon" | "rightArrowIcon" | "renderDay" | "allowKeyboardControl"'.
ERROR in node_modules/material-ui-pickers/DateTimePicker/components/DateTimePickerHeader.d.ts(18,82):
TS2344: Type '"date" | "classes" | "innerRef" | "ampm" | "openView" | "meridiemMode" | "onOpenViewChange" | "setMeridiemMode"' does not satisfy the constraint '"date" | "classes" | "utils" | "ampm" | "openView" | "meridiemMode" | "onOpenViewChange" | "setMeridiemMode"'.
  Type '"innerRef"' is not assignable to type '"date" | "classes" | "utils" | "ampm" | "openView" | "meridiemMode" | "onOpenViewChange" | "setMeridiemMode"'.
ERROR in node_modules/material-ui-pickers/TimePicker/TimePicker.d.ts(45,72):
TS2344: Type '"date" | "seconds" | "classes" | "onChange" | "innerRef" | "theme" | "ampm"' does not satisfy the constraint '"date" | "seconds" | "classes" | "onChange" | "theme" | "utils" | "ampm"'.
  Type '"innerRef"' is not assignable to type '"date" | "seconds" | "classes" | "onChange" | "theme" | "utils" | "ampm"'.

Live example

@Weffe
Copy link

Weffe commented Feb 4, 2019

I am getting the same error

@bdchauvette
Copy link

bdchauvette commented Feb 6, 2019

Looks like this was probably caused by mui/material-ui#14333, which removed the innerRef field from WithStyles.

@benneq
Copy link
Author

benneq commented Feb 7, 2019

Works now with 2.2.0

@benneq benneq closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants