Skip to content

[combobox] Fix unexpected close with multiple selection and input inside popup #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

[combobox] Fix unexpected close with multiple selection and input inside popup #2771

merged 1 commit into from
Sep 18, 2025

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Sep 16, 2025

The popup should only close in this scenario if the input isn't inside the popup.

@atomiks atomiks added type: bug It doesn't behave as expected. component: combobox Changes related to the combobox component. labels Sep 16, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 16, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2771

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2771

commit: 0d32af4

@mui-bot
Copy link

mui-bot commented Sep 16, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+28B(+0.01%) 🔺+5B(0.00%)

Details of bundle changes

@netlify
Copy link

netlify bot commented Sep 16, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 0d32af4
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68c8df332ec6a800082a41b3
😎 Deploy Preview https://deploy-preview-2771--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks marked this pull request as ready for review September 16, 2025 04:00
mnajdova
mnajdova approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work as expected 👌

@atomiks atomiks merged commit 74377e0 into mui:master Sep 18, 2025
21 checks passed
@atomiks atomiks deleted the fix/combobox-multiple-input-inside-popup branch September 18, 2025 05:32
@brijeshb42 brijeshb42 mentioned this pull request Sep 24, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnajdova mnajdova mnajdova approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees

No one assigned

Labels

component: combobox Changes related to the combobox component. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atomiks @mui-bot @mnajdova