Skip to content

[docs][accordion][toolbar] Fix ToolbarButton, and ToolbarInput to use proper state types #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 12, 2025
Merged

[docs][accordion][toolbar] Fix ToolbarButton, and ToolbarInput to use proper state types #2732

merged 5 commits into from
Sep 12, 2025

Conversation

@chuganzy
Copy link
Contributor

@chuganzy chuganzy commented Sep 11, 2025

Related: #2697

This is a minor PR to fix AccordionPanel, ToolbarButton, and ToolbarInput to use proper state types.

@chuganzy chuganzy marked this pull request as draft September 11, 2025 14:21
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 11, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2732

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2732

commit: 0247de5

@netlify
Copy link

netlify bot commented Sep 11, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 0247de5
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68c371119a92a300089ce046
😎 Deploy Preview https://deploy-preview-2732--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chuganzy chuganzy marked this pull request as ready for review September 11, 2025 14:23
@chuganzy chuganzy changed the title [accordion][toolbar] Fix ToolbarButton, and ToolbarInput to use proper state types [docs][accordion][toolbar] Fix ToolbarButton, and ToolbarInput to use proper state types Sep 11, 2025
@mui-bot
Copy link

mui-bot commented Sep 11, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

@mj12albert mj12albert merged commit 7074998 into mui:master Sep 12, 2025
19 checks passed
@chuganzy
Copy link
Contributor Author

chuganzy commented Sep 12, 2025

@mj12albert Thank you for reviewing and merging! Could you please also add appropriate PR labels when you have a chance? Thanks!

@mj12albert mj12albert added docs Improvements or additions to the documentation. component: accordion Changes related to the accordion component. component: toolbar Changes related to the toolbar component. labels Sep 12, 2025
@chuganzy chuganzy mentioned this pull request Sep 12, 2025
Merged
1 task
@chuganzy chuganzy deleted the fix-state-types branch September 12, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mj12albert mj12albert mj12albert approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees

No one assigned

Labels

component: accordion Changes related to the accordion component. component: toolbar Changes related to the toolbar component. docs Improvements or additions to the documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chuganzy @mui-bot @mj12albert