Skip to content

[combobox] Fix input focus on close when clicking trigger #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2025
Merged

[combobox] Fix input focus on close when clicking trigger #2723

merged 1 commit into from
Sep 14, 2025

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Sep 11, 2025 •
edited
Loading

Prevents the input from taking focus when clicking the trigger to close. In Safari, the page can scroll to the bottom when toggling with the trigger.

Fixes #2757

@atomiks atomiks added type: bug It doesn't behave as expected. browser: Safari Affects or fixes behavior in Apple Safari. scope: autocomplete component: combobox Changes related to the combobox component. labels Sep 11, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 11, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2723

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2723

commit: 21065aa

@netlify
Copy link

netlify bot commented Sep 11, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 21065aa
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68c33475c207620008152a8e
😎 Deploy Preview https://deploy-preview-2723--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui-bot
Copy link

mui-bot commented Sep 11, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+20B(+0.01%) 🔺+14B(+0.01%)

Details of bundle changes

@atomiks atomiks force-pushed the fix/combobox-input-focus-close branch from 856e541 to 21065aa Compare September 11, 2025 20:43
@atomiks atomiks mentioned this pull request Sep 13, 2025
Closed
@atomiks atomiks merged commit a4606cf into mui:master Sep 14, 2025
19 checks passed
@atomiks atomiks deleted the fix/combobox-input-focus-close branch September 14, 2025 21:45
@brijeshb42 brijeshb42 mentioned this pull request Sep 24, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mj12albert mj12albert mj12albert approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees

No one assigned

Labels

browser: Safari Affects or fixes behavior in Apple Safari. component: combobox Changes related to the combobox component. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[combobox] Only on Safari the page jumps to button when using a Trigger to close a Popup with an Input inside it

3 participants

@atomiks @mui-bot @mj12albert