-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Fix prettier ci task with multiple changed files #12579
Conversation
This does work locally |
The current approach relies on I have no idea how to get a commit range from master to branch in CircleCI otherwise. #12564 should be reverted if no one else has solution. |
9b25d39
to
5e5968c
Compare
The |
7b51d55
to
c37d493
Compare
c37d493
to
3916776
Compare
Thanks for the hint @oliviertassinari. Responsible for the unexpected I had to work around CircleCIs missing support for interpolation while setting environment variables quite a bit. The prettier step now exited as expected on the following test case: |
Thanks. I wish we had a detailed diff of what's wrong (like before) rather than just the files that need to be fixed, but it's not that important (easier to graspe for a new contributor). Let's try that out. |
While this is useful for linting since most of those issues need to be resolved manually formatting should not be done manually. That should either be handled by the IDE or via |
Fixes various issues in #12564:
Sorry about the inconvenience. I should've been more careful with languages that I'm not that familiar with.
The build should be considered broken. Once this is confirmed I will retrigger with only one file changed and the remove the broken format completely. Only if all those builds return as expected should this be merged.