Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect extension detection in case of file-names without extension #10

Open
MikiDi opened this issue Jul 6, 2021 · 2 comments
Open

Comments

@MikiDi
Copy link
Contributor

MikiDi commented Jul 6, 2021

See

file_extension = upload_resource_name.split('.').last
.
A file named README for example, would result in a triple containing the extension as README, which is incorrect. This should be no triple or an explicit empty value instead.

@MikiDi MikiDi changed the title Incorrect extension detection in case of files without extension Incorrect extension detection in case of file-names without extension Jul 6, 2021
@sergiofenoll
Copy link

For files with spaces in the name, this fully breaks the upload. Since the file name is considered to be the extension, the physical file URI will have (unescaped) spaces in it, which causes Virtuoso to crash.

@nvdk
Copy link
Member

nvdk commented Mar 28, 2024

For files with spaces in the name, this fully breaks the upload. Since the file name is considered to be the extension, the physical file URI will have (unescaped) spaces in it, which causes Virtuoso to crash.

FYI I believe this is fixed in later versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants