Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically pick the correct vertex-centered cut based on the vertex figure #7

Closed
roice3 opened this issue Mar 21, 2018 · 3 comments

Comments

@roice3
Copy link
Collaborator

roice3 commented Mar 21, 2018

The two scene options Sphere_horosphere and Sphere_plane are a bit awkward because we can automatically pick the correct cut for a vertex (sphere, horosphere, plane) depending on whether the vertex figure is spherical, euclidean, or hyperbolic. Though it can produce cool looking results, it doesn't really make sense to construct a horosphere cut when you have a hyperbolic vertex figure.

Another option would be to have separate scenes for whether to include cell-centered cuts, vertex-centered cuts, or both.

@henryseg
Copy link
Collaborator

I agree, let's have it choose the correct cut for the geometry. The only problem is deciding what it should be called...

@roice3
Copy link
Collaborator Author

roice3 commented Apr 5, 2018

Issue #19 is relevant to this.

@roice3 roice3 closed this as completed in 06136ee Apr 6, 2018
@roice3
Copy link
Collaborator Author

roice3 commented Apr 6, 2018

I called this "Simplex_cuts", though it is easy to change if there are better thoughts. I don't like Simplex_cuts much, but couldn't think of anything better that was short.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants