Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings with mySQL #31

Open
Jarod42 opened this issue Nov 3, 2024 · 3 comments
Open

Build warnings with mySQL #31

Jarod42 opened this issue Nov 3, 2024 · 3 comments

Comments

@Jarod42
Copy link

Jarod42 commented Nov 3, 2024

From CI: https://github.com/Jarod42/wxDatabase/actions/runs/11632894931/job/32396938912

/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:134:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:134:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:134:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:148:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:148:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:148:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:1[90](https://github.com/Jarod42/wxDatabase/actions/runs/11632894931/job/32396938912#step:6:91):37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:190:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:190:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:202:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:202:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:202:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:217:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:217:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:217:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:260:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
    if ((*(pResultBinding->is_null) == false))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:260:37: note: remove extraneous parentheses around the comparison to silence this warning
    if ((*(pResultBinding->is_null) == false))
        ~                           ^       ~
/Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_preparedStatement_resultset.cpp:260:37: note: use '=' to turn this equality comparison into an assignment
    if ((*(pResultBinding->is_null) == false))
                                    ^~
                                    =
In file included from /Users/runner/work/wxDatabase/wxDatabase/src/database/mysql/mysql_resultset_metadata.cpp:5:
/opt/homebrew/include/mysql/mysql_com.h:3:2: warning: This file should not be included by clients, include only <mysql.h> [-W#warnings]
#warning This file should not be included by clients, include only <mysql.h>
 ^
1 warning generated.
6 warnings generated.
@Jarod42
Copy link
Author

Jarod42 commented Nov 3, 2024

Fixed by https://github.com/Jarod42/wxDatabase/tree/warnings
Waiting previous PR about CI before to submit this one.

@mtangoo
Copy link
Owner

mtangoo commented Nov 15, 2024

Thanks, I have been having a tough week, but have not forgotten this one and the other one. I hope to come to it over the weekend and fix it!

@Jarod42
Copy link
Author

Jarod42 commented Nov 15, 2024

No urgency on my side.
Several changes would be incoming in long term :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants