-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky: "msw-api/context/delay.test.ts" integration test #276
Comments
Hey, @JacobMGEvans! This is that flaky test issue we've been discussing on Discord. Please, feel free to take a look into it, if you have some spare time. I'd be thankful. |
Alright thanks! I will be able to take a look. Sorry for the delay I was experiences burnout pretty bad but I am back 😄 |
@kettanaito where is the discord server? I didn't find a link anywhere in the README or on the doc site. Is it public? |
I got you @cowboyd https://discord.com/channels/715220730605731931/727558537919594506 |
Thanks @JacobMGEvans!, but I'm getting that the invite is invalid or expired. Is that channel link, not an invite link maybe? |
Give me a minute. |
https://kentcdodds.com/discord @cowboyd This should work. The MSW is in one of the channels 😄 |
So I ran the tests locally with a script about 100 times, it broke on the 150 deviations about 30% if the time pretty consistently. I tried running it on a faster machine to make sure it wasn't resources related and added Jest Workers to the pool, it was pretty much the same. |
Scope
Current behavior
Current deviation value (
150
ms) is not sufficient to cover the random response time generated byctx.delay()
.Expected behavior
Integration test for implicit response delay passes. I recommend to setup a simple Shell script that would run that test numerous times (i.e. 100) and ensure all the runs pass.
Suggested solution
200
ms.The text was updated successfully, but these errors were encountered: