Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency on interceptors #1493

Closed
1 task
pollyoaks opened this issue Dec 8, 2022 · 1 comment
Closed
1 task

Bump dependency on interceptors #1493

pollyoaks opened this issue Dec 8, 2022 · 1 comment
Labels

Comments

@pollyoaks
Copy link

pollyoaks commented Dec 8, 2022

Scope

Improves an existing behavior

Compatibility

  • This is a breaking change

Feature description

Hi there 👋
Currently, the latest version of msw is using an outdated version of the mswjs/interceptors package (0.17.5) , that specific version depends on an old version of xmldom which is causing a security risk.

The latest version of mswjs/interceptors solves this issue (this was actually fixed in this version), can we please have it upgraded?

@kettanaito
Copy link
Member

kettanaito commented Dec 10, 2022

Hey, @pollyoaks. The xmldom dependency is removed entirely since @mswjs/[email protected] but 0.18.0 introduces breaking changes that aren't reasonable to migrate to in the current state of MSW. I'm working on that migration in #1436 that's going to be released in Q1 of 2023 (hopefully).

MSW is a development tool so any security risks it poses apply only to you and your team while developing. This drops the severity of any security risk compared to having it in the code you ship to your customers. That being said, if you're absolutely blocked by this, you can always override the version of xmldom you install in your package.json. You can use Yarn resolutions or NPM overrides for that.

Using Yarn resolutions

{
 "resolutions": {
    "@xmldom/xmldom": "x.y.z"
  }
}

Using NPM overrides

{
  "overrides": {
    "@xmldom/xmldom": "x.y.z"
  }
}

You can learn more about those settings in their respective documentations.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants