Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull up enabled by default on RPM pin #146

Open
romoloman opened this issue Sep 16, 2024 · 0 comments
Open

Pull up enabled by default on RPM pin #146

romoloman opened this issue Sep 16, 2024 · 0 comments

Comments

@romoloman
Copy link

romoloman commented Sep 16, 2024

OXS leave puls enabled on pins used as digital inputs like RPM pin.
Some optical sensors that uses an LM353 comparator have not enough low impedance to drive the input low, thus the rpm edge detection never happens.
I think it would be better to leave pulls disabled by adding in setuprpm function something like:
gpio_disable_pulls(config.pinRpm); //disable pullup/pulldown on rpm pin
just after having checked that the pin is defined and leaving to an external pull-up or pull-down the duty to pull the pin if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant