Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple message-paths and concatenate them. #90

Closed
mshick opened this issue Apr 26, 2023 · 4 comments
Closed

Support multiple message-paths and concatenate them. #90

mshick opened this issue Apr 26, 2023 · 4 comments

Comments

@mshick
Copy link
Owner

mshick commented Apr 26, 2023

No description provided.

@mshick mshick converted this from a draft issue Apr 26, 2023
@kishaningithub
Copy link

kishaningithub commented May 3, 2023

Given #93 i feel there should be an option which creates multiple comments if multiple-paths are given. That way there can probably be a step before calling this action which splits a very big comment into multiple comments and puts them in separate files. what do you think?

@mshick
Copy link
Owner Author

mshick commented May 4, 2023

@kishaningithub For #93 my preference would be to check the size of the message and break it into parts if we're going to hit the limit.

The use you describe above seems like it could be handled better by multiple instances of the action, for example:

on:
  pull_request:

jobs:
  pr:
    runs-on: ubuntu-latest
    permissions:
      pull-requests: write
    steps:
      - uses: mshick/add-pr-comment@v2
        with:
          message-id: foo
          message-path: |
            foo/*.txt

      - uses: mshick/add-pr-comment@v2
        with:
          message-id: bar
          message-path: |
            bar/*.txt

@mshick mshick closed this as completed May 4, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in add-pr-comment May 4, 2023
@mshick
Copy link
Owner Author

mshick commented May 4, 2023

@kishaningithub Feel free to open a new issue if you have suggestions for improvements to the concatenation feature.

@kishaningithub
Copy link

I never realised that message-path supports globs. Thanks a lot for that example! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants