Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby's ExtensionValue, can't access type and payload #55

Closed
ramonmaruko opened this issue Apr 12, 2015 · 4 comments
Closed

JRuby's ExtensionValue, can't access type and payload #55

ramonmaruko opened this issue Apr 12, 2015 · 4 comments

Comments

@ramonmaruko
Copy link

Is this intended? How do I access the type and payload properly in Ruby code?

cc @iconara

@iconara
Copy link
Member

iconara commented Apr 12, 2015

If I remember correctly it's not a finished feature. The JRuby version of msgpack-ruby was in a transition from the old API and old MessagePack standard to the API msgpack-ruby has now and the new MessagePack standard when it got merged in, and I haven't had any time to complete that transition.

If you're using MessagePack extensions and have the time we would be happy to see a PR that adds accessors for type and payload to ExtensionValue. It wouldn't hurt with a few tests around encoding and decoding extensions too.

@ramonmaruko
Copy link
Author

I'll try to add that to JRuby when I have free time. I already submitted a pull request #14 with a few tests; but only for MRI for now.

@iconara
Copy link
Member

iconara commented Apr 12, 2015

That would be great, thank you.

@tagomoris
Copy link
Member

#84 already solved this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants