Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FEATURE ] rocketicon support #162

Open
Ashraf-Ali-aa opened this issue Jun 9, 2024 · 4 comments
Open

[ FEATURE ] rocketicon support #162

Ashraf-Ali-aa opened this issue Jun 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Ashraf-Ali-aa
Copy link

Ashraf-Ali-aa commented Jun 9, 2024

Adding support for rocket icons would make it's easier to work with icons via tailwind https://github.com/rocketclimb/rocketicons

@Ashraf-Ali-aa Ashraf-Ali-aa added the enhancement New feature or request label Jun 9, 2024
@mrzachnugent
Copy link
Owner

@Ashraf-Ali-aa I am unfamiliar with that library. From a quick look, I didn't see how to use the custom css variables. Do you know how this would be done?

Do you know how it affects the build size of the application? There seems to be a lot of icon libraries. Lucide Icons offers a way to use a generic icon. We do not use it since it would significantly increase the build size of the application.

Source https://lucide.dev/guide/packages/lucide-react-native#one-generic-icon-component

@Ashraf-Ali-aa
Copy link
Author

@mrzachnugent have a look at the demo on the website https://rocketicons.io/en It just using the tailwind CSS values, regarding build size I think they are using es6 imports

@mrzachnugent
Copy link
Owner

@Ashraf-Ali-aa From the example, I don't see an icon-primary-foreground-lg like example where the icon uses the custom css variables.

Do you use this library?

@Ashraf-Ali-aa
Copy link
Author

@Ashraf-Ali-aa From the example, I don't see an icon-primary-foreground-lg like example where the icon uses the custom css variables.

Do you use this library?

unless I misunderstood,
you can extend the tailwind config to add the custom variable like https://rocketicons.io/en/docs/getting-started then use the variable for the icon, I want to use it in conjunction with this library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants