Gradle build failed for the Expo Android Fix Pre-release #546

haibert · 2021-10-21T05:32:42Z

What were you trying to do?

Trying to install Vision Camera on android and do a successful expo build.

Reproduceable Code

No response

What happened instead?

FAILURE: Build failed with an exception.

Relevant log output

[stderr] FAILURE: Build failed with an exception. [stderr] * What went wrong: [stderr] Execution failed for task ':app:mergeDebugNativeLibs'. [stderr] > A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade [stderr] > More than one file was found with OS independent path 'lib/x86_64/libreactnativejni.so'. If you are using jniLibs and CMake IMPORTED targets, see https://developer.android.com/studio/preview/features#automatic_packaging_of_prebuilt_dependencies_used_by_cmake [stderr] * Try: [stderr] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. [stderr] * Get more help at https://help.gradle.org [stderr] BUILD FAILED in 7m 29s🐛

Device

iPhone 12 iOS 14

VisionCamera Version

2.9.4@expo

Additional information

I am using Expo
I have read the Troubleshooting Guide
I agree to follow this project's Code of Conduct
I searched for similar issues in this repository and found none.

The text was updated successfully, but these errors were encountered:

mrousavy · 2021-10-21T11:51:34Z

Thanks for the bug report!
If you want to fix it, add libreactnativejni.so there:

react-native-vision-camera/android/build.gradle

Lines 113 to 115 in 7206a79

    
           packagingOptions { 
        
             excludes = ["**/libc++_shared.so", "**/libfbjni.so", "**/libjsi.so"] 
        
           }

TooAngel · 2021-10-22T09:33:51Z

I ran into the same issue (without expo), the solution works for me, thanks.

haibert · 2021-10-22T14:37:34Z

@mrousavy can we please get a update with the change you need mentioned since expo people can't touch the gradle❤️🙏🏻

yoann84 · 2021-11-19T14:07:53Z

@haibert Did you find a workaround for that ?

haibert · 2021-11-19T15:16:51Z

@yoann84 im pretty sure yesterday my build was successful while using the expo .11 version with no problems, are you on expo v43 ?

yoann84 · 2021-11-19T15:45:46Z

Sorry but what is expo 0.11 ? yes i'm on sdk43 and on android I have similar error. When I try to fix one I got another one and wtih expo as we can't modify gradle files and configuration even if I found a workaround it won't work in production

haibert · 2021-11-19T16:08:14Z

@yoann84 no worries, just run the following expo install react-native-vision-camera@expo

Heres the full discussion.
#545

hirbod · 2021-12-20T02:07:39Z

I can't for my life build the android app on SDK 44 (custom dev client)
Works flawless on iOS but android keeps crashing. I've installed the expo tag, appield JHashMap patches and followed every thing I could find:

* What went wrong:
Execution failed for task ':app:mergeDebugNativeLibs'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
   > More than one file was found with OS independent path 'lib/x86/libc++_shared.so'. If you are using jniLibs and CMake IMPORTED targets, see https://developer.android.com/studio/preview/features#automatic_packaging_of_prebuilt_dependencies_used_by_cmake

haibert · 2021-12-21T01:01:47Z

@hirbod Marc is working on a fix he just doesn't have enough time to dedicate to backwards compatibility.(because I think vision camera works fine with RN .65 and above) He might work on the fix when he finds free time. Also soon expo will allow us to have more complex managed work flow which will make supporting complex modules like this easier. This is according to the man him self Evan Bacon. Hope this gives you some hope until a fix is provided either from Marc or from expo!

hirbod · 2021-12-21T01:05:09Z

@haibert I just talked with Marc today via twitter. He tries to fix this in the holidays.

sandlands · 2021-12-24T14:01:20Z

Thanks for the bug report! If you want to fix it, add libreactnativejni.so there:

react-native-vision-camera/android/build.gradle

Lines 113 to 115 in 7206a79

packagingOptions {

excludes = ["**/libc++_shared.so", "**/libfbjni.so", "**/libjsi.so"]

}

Thanks, @mrousavy. I stumbled upon similar error messages for other libraries. I ended up with:
excludes = ["**/libc++_shared.so", "**/libfbjni.so", "**/libjsi.so", "**/libreactnativejni.so", "**/libfolly_json.so", "**/libreanimated.so", "**/libjscexecutor.so"]

Finally, I managed to build for Android, using Expo's eas build in my case. This is what I did:

I'm using Expo SDK 44 and built a Development Client (using eas build).
I'm using [email protected] (and [email protected])
I installed patch-package in my project (see patch-package Setup section)
I patched node_modules/react-native-vision-camera (with the patch above and these JSI patches, setting VisionCamera_compileSdkVersion=30), which resulted in an added patches/react-native-vision-camera+2.9.4.patch to my app home directory (which will be used by eas build). Below you find the complete content of this patch.
Add these changes to the bottom of my-app/android/app/build.gradle.

I hope this helps anyone.

Kind regards,
Sander

my-app/patches/react-native-vision-camera+2.9.4.patch:

diff --git a/node_modules/react-native-vision-camera/android/CMakeLists.txt b/node_modules/react-native-vision-camera/android/CMakeLists.txt
index ab15dc3..844e768 100644
--- a/node_modules/react-native-vision-camera/android/CMakeLists.txt
+++ b/node_modules/react-native-vision-camera/android/CMakeLists.txt
@@ -22,6 +22,7 @@ add_library(
         src/main/cpp/java-bindings/JFrameProcessorPlugin.cpp
         src/main/cpp/java-bindings/JImageProxy.cpp
         src/main/cpp/java-bindings/JHashMap.cpp
+        ${NODE_MODULES_DIR}/react-native/ReactCommon/jsi/jsi/jsi.cpp
 )
 
 # includes
@@ -87,12 +88,6 @@ find_library(
         PATHS ${LIBRN_DIR}
         NO_CMAKE_FIND_ROOT_PATH
 )
-find_library(
-        JSI_LIB
-        jsi
-        PATHS ${LIBRN_DIR}
-        NO_CMAKE_FIND_ROOT_PATH
-)
 find_library(
         FOLLY_JSON_LIB
         folly_json
@@ -125,7 +120,6 @@ message(WARNING "VisionCamera linking: FOR_HERMES=${FOR_HERMES}")
 target_link_libraries(
         ${PACKAGE_NAME}
         ${LOG_LIB}
-        ${JSI_LIB}
         ${JS_ENGINE_LIB} # <-- Hermes or JSC
         ${REANIMATED_LIB}
         ${REACT_NATIVE_JNI_LIB}
diff --git a/node_modules/react-native-vision-camera/android/build.gradle b/node_modules/react-native-vision-camera/android/build.gradle
index f3ffea4..ed987e4 100644
--- a/node_modules/react-native-vision-camera/android/build.gradle
+++ b/node_modules/react-native-vision-camera/android/build.gradle
@@ -111,7 +111,7 @@ android {
   }
 
   packagingOptions {
-    excludes = ["**/libc++_shared.so", "**/libfbjni.so", "**/libjsi.so"]
+    excludes = ["**/libc++_shared.so", "**/libfbjni.so", "**/libjsi.so", "**/libreactnativejni.so", "**/libfolly_json.so", "**/libreanimated.so", "**/libjscexecutor.so"]
   }
 
   buildTypes {
@@ -466,7 +466,7 @@ extractJNIFiles.mustRunAfter extractAARHeaders
 // pre-native build pipeline
 
 tasks.whenTaskAdded { task ->
-  if (task.name == 'externalNativeBuildDebug' || task.name == 'externalNativeBuildRelease') {
+  if (task.name.contains('externalNative') || task.name.contains('CMake')) {
     task.dependsOn(extractAARHeaders)
     task.dependsOn(extractJNIFiles)
     task.dependsOn(prepareJSC)
diff --git a/node_modules/react-native-vision-camera/android/gradle.properties b/node_modules/react-native-vision-camera/android/gradle.properties
index d171611..b08ddc8 100644
--- a/node_modules/react-native-vision-camera/android/gradle.properties
+++ b/node_modules/react-native-vision-camera/android/gradle.properties
@@ -12,7 +12,7 @@
 # org.gradle.parallel=true
 #Fri Feb 19 20:46:14 CET 2021
 VisionCamera_buildToolsVersion=30.0.0
-VisionCamera_compileSdkVersion=31
+VisionCamera_compileSdkVersion=30
 VisionCamera_kotlinVersion=1.5.30
 VisionCamera_targetSdkVersion=31
 VisionCamera_ndkVersion=21.4.7075529

haibert · 2021-12-24T18:11:53Z

@sandlands I can confirm that this approach works! Thanks a lot Sander.
I did one thing differently, instead of modifying my apps build.gradle manually I used a config plug in to keep my work flow in the managed state. I also should mention this still fails if you have hermes enabled on android. I had to disable it to stop the builds from failing.

to do this you will need the following config plugin. Courtesy of @mercyaj

const { withProjectBuildGradle } = require('@expo/config-plugins')

const setCompileSdkVersion = (buildGradle, sdkVersion) => {
    const regexpCompileSdkVersion = /\bcompileSdkVersion\s*=\s*(\d+)/
    const match = buildGradle.match(regexpCompileSdkVersion)

    if (match) {
        const existingVersion = parseInt(match[1], 10)

        if (existingVersion < sdkVersion) {
            buildGradle = buildGradle.replace(
                /\bcompileSdkVersion\s*=\s*\d+/,
                `compileSdkVersion = ${sdkVersion}`
            )
        } else {
            throw new Error(`minSdkVersion is already >= ${sdkVersion}`)
        }
    }

    return buildGradle
}

module.exports = (config, sdkVersion) => {
    return withProjectBuildGradle(config, (config) => {
        if (config.modResults.language === 'groovy') {
            config.modResults.contents = setCompileSdkVersion(
                config.modResults.contents,
                sdkVersion
            )
        } else {
            throw new Error(
                "Can't set minSdkVersion in the project build.gradle, because it's not groovy"
            )
        }
        return config
    })
}

Then inside of app.json
//---------------IN APP.JSON-----------------

"plugins": [
            "react-native-vision-camera",
            ["./withCompileSdkVersion", 31]
        ]

//---------------IN APP.JSON-----------------

BTW you can use the most recent release with these diffs, you dont need to use 2.9.4.

hirbod · 2021-12-24T19:09:51Z

That’s awesome news. I will try this later. Haven’t been able to build Android for days

hirbod · 2021-12-24T23:32:19Z

@haibert did you still use the same patch file or did you edit it? I see the patchfile contains change to the minSdkVersion from 31 to 30 and you supplied a configPlugin to set 30 to 31 :D

haibert · 2021-12-25T00:36:21Z

@hirbod yea I made a mistake there lol but it still works. You can ignore that step if you use the plugin.. and I should also mention I had to turn off hermes engine on android or else the build was still failing.. make sure you dont have "jsEngine": "hermes" in your app.jsons android property.

hirbod · 2021-12-25T10:21:41Z

Oh no. I won’t build my app without Hermes this time. Going to wait for a real fix by Marc

haibert added the 🐛 bug Something isn't working label Oct 21, 2021

mrousavy mentioned this issue Dec 13, 2021

Prepare for Fabric / TurboModules #650

Closed

sandlands mentioned this issue Dec 24, 2021

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.🐛 #588

Closed

4 tasks

haibert mentioned this issue Dec 24, 2021

Updates to fix android builds failing in Expo #676

Closed

sandlands mentioned this issue Dec 31, 2021

🐛 Android build failure: "Multiple task action failures occurred" #515

Closed

4 tasks

mrousavy mentioned this issue Jan 2, 2022

fix: Fix Android build on React Native 0.65 and older #694

Merged

mrousavy closed this as completed in #694 Jan 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gradle build failed for the Expo Android Fix Pre-release #546

Gradle build failed for the Expo Android Fix Pre-release #546

haibert commented Oct 21, 2021 •

edited

Loading

mrousavy commented Oct 21, 2021

TooAngel commented Oct 22, 2021

haibert commented Oct 22, 2021

yoann84 commented Nov 19, 2021

haibert commented Nov 19, 2021

yoann84 commented Nov 19, 2021

haibert commented Nov 19, 2021

hirbod commented Dec 20, 2021

haibert commented Dec 21, 2021 •

edited

Loading

hirbod commented Dec 21, 2021

sandlands commented Dec 24, 2021

haibert commented Dec 24, 2021 •

edited

Loading

hirbod commented Dec 24, 2021

hirbod commented Dec 24, 2021

haibert commented Dec 25, 2021

hirbod commented Dec 25, 2021

Gradle build failed for the Expo Android Fix Pre-release #546

Gradle build failed for the Expo Android Fix Pre-release #546

Comments

haibert commented Oct 21, 2021 • edited Loading

What were you trying to do?

Reproduceable Code

What happened instead?

Relevant log output

Device

VisionCamera Version

Additional information

mrousavy commented Oct 21, 2021

TooAngel commented Oct 22, 2021

haibert commented Oct 22, 2021

yoann84 commented Nov 19, 2021

haibert commented Nov 19, 2021

yoann84 commented Nov 19, 2021

haibert commented Nov 19, 2021

hirbod commented Dec 20, 2021

haibert commented Dec 21, 2021 • edited Loading

hirbod commented Dec 21, 2021

sandlands commented Dec 24, 2021

haibert commented Dec 24, 2021 • edited Loading

hirbod commented Dec 24, 2021

hirbod commented Dec 24, 2021

haibert commented Dec 25, 2021

hirbod commented Dec 25, 2021

haibert commented Oct 21, 2021 •

edited

Loading

haibert commented Dec 21, 2021 •

edited

Loading

haibert commented Dec 24, 2021 •

edited

Loading