-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
❓ 2.8.0 > 2.9.1 - Android build error: JSI_LIB not found #513
Comments
Nevermind, looks like the cause of the issue is something else. Will investigate further. Edit - On further testing, this issue only occurs if I switch to 2.9.0 or 2.9.1. |
In previous issues, there was a bug that 2.9.0/2.9.1 was working only with RN 66, but RN 66 currently doesn't work with the current version react-native-reanimated. |
Thanks for the tip @Hajan39 , didn't see that. Downgrading |
To patch this, you need to remove these: react-native-vision-camera/android/CMakeLists.txt Lines 90 to 95 in 3315f51
and this:
line in your local node_modules. I'll try to figure out a way to make that CMake dependency optional... |
Thanks for that, all good now. |
This comment has been minimized.
This comment has been minimized.
In my case fixing it locally is not a good solution because many people have to develop on this app. |
@D4nt4lion Patch Package can help with that - https://www.npmjs.com/package/patch-package |
@D4nt4lion alternatively if you're using yarn 2, you can use |
[android, didn't check iOS]
errors in terminal with patch package solution
errors without patch package solution
|
Any update on this issue? Still doesn't work on Android. |
Any update? 🥲 |
here is the juicy part about this error
here is the full error In file included from ../../../../src/main/cpp/JSIJNIConversion.cpp:25:
../../../../src/main/cpp/java-bindings/JHashMap.h:16:8: error: redefinition of 'JHashMap'
../../../../build/fbjni-0.3.0-headers.jar/fbjni/detail/Iterator.h:170:8: note: previous definition is here
In file included from ../../../../src/main/cpp/java-bindings/JHashMap.cpp:5:
../../../../src/main/cpp/java-bindings/JHashMap.h:16:8: error: redefinition of 'JHashMap'
../../../../build/fbjni-0.3.0-headers.jar/fbjni/detail/Iterator.h:170:8: note: previous definition is here
../../../../src/main/cpp/java-bindings/JHashMap.cpp:15:43: error: redefinition of 'create'
../../../../build/fbjni-0.3.0-headers.jar/fbjni/detail/Iterator-inl.h:230:42: note: previous definition is here |
@TheEhsanSarshar update to version 2.9.4 this is solved. |
Thank you so much @Hajan39 |
The only way I was able to fix this issue was updating my
I used this tool also Make sure to follow to download the latest NDK specified via SDK manager and update your |
Expo SDK 44, Custom Dev Client, I get:
|
still have error when building for Android, any update ? |
I am still getting this error too. |
I am still getting this error too. react-native-vision-camera 2.12.1 |
I met this kind of Error and solved it by uninstall and reinstall react-native-vision-camera. "react-native-vision-camera": "^2.12.2",
|
Can you paste more log output? There's no error here. Maybe try cleaning everything and making sure your NDK and CMake is installed correctly via Android Studio |
Cleaning everything (re-install library) works! thanks for great library! 😁 |
Awesome, nice to hear! |
In iOS compiled with success. But in android I'm getting both error, like you. With or without the patch fix |
Which RN versions are you on? Compare your versions with the Example/ app here |
You must only install C++ sdk to your pc. and do the following processes respectively:
|
Question
Hi,
I'm attempting to upgrade from RNVC 2.8 > 2.9 and hitting a build error:
Observations:
npx react-native init ProjectName
)Repo+branch demonstrating the issue here
Full Build Log: rnvc2.9.1-build-error.log
The offending CMakeLists.txt: ~\node_modules\react-native-vision-camera\android\CMakeLists.txt
I'm stumped. Any thoughts on what I'm doing wrong?
What I tried
npm run android
and Android StudioVisionCamera Version
2.9.0 and 2.9.1
Additional information
The text was updated successfully, but these errors were encountered: