Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint: Improve config #29981

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Eslint: Improve config #29981

merged 2 commits into from
Nov 29, 2024

Conversation

s-rigaud
Copy link
Contributor

Description

I figured out from reading PRs or making one that some eslint rules might be added to the project to improve code quality.

As the core developers will be mainly impacted by the rule changes, you are in a better spot to judge what rules should be added or not. This PR is just a small suggestion.

I updated the code with new rules to get a preview of the changes (there is no error left).

Copy link

github-actions bot commented Nov 27, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.14
78.99
339.14
78.99
+0 B
+0 B
WebGPU 484.69
134.48
484.69
134.48
+0 B
+0 B
WebGPU Nodes 484.15
134.38
484.15
134.38
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.61
111.98
464.61
111.98
+0 B
+0 B
WebGPU 553.43
149.79
553.43
149.79
+0 B
+0 B
WebGPU Nodes 509.31
139.5
509.31
139.5
+0 B
+0 B

.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 29, 2024

Do you mind resolving the merge conflicts?

@Mugen87 Mugen87 merged commit 3e54130 into mrdoob:dev Nov 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants