Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getTypedArray unit test fails on browsers #23257

Closed
takahirox opened this issue Jan 17, 2022 · 0 comments · Fixed by #23258
Closed

getTypedArray unit test fails on browsers #23257

takahirox opened this issue Jan 17, 2022 · 0 comments · Fixed by #23258
Labels
Bug

Comments

@takahirox
Copy link
Collaborator

Describe the bug

getTypedArray unit test fails on browsers while it passes on Node.js

To Reproduce

Steps to reproduce the behavior:

  1. $ npm run test-unit and see all the test pass on Node.js
  2. $ npm run start
  3. Access http://localhost:8080/test/unit/UnitTests.html on a web browser and see the utils: getTypedArray unit fails.

Expected behavior

The unit test passes.

Screenshots

image

The root issue seems ReferenceError: Buffer is not defined. I speculate Buffer seems Node.js specific and it isn't available on browsers.

Platform:

  • Device: Desktop
  • OS: Windows
  • Browser: Chrome
  • Three.js version: dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix utils: getTypedArray unit test. takahirox/three.js
2 participants
@takahirox @Mugen87